Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pipeable-operators): correct sample output in "takeEveryNth" example #3398

Merged
merged 1 commit into from
Mar 7, 2018
Merged

docs(pipeable-operators): correct sample output in "takeEveryNth" example #3398

merged 1 commit into from
Mar 7, 2018

Conversation

corg
Copy link
Contributor

@corg corg commented Mar 7, 2018 •
edited

Description:

An example in pipepable-operators.md showed incorrect sample output:

interval(1000).pipe(
  takeEveryNth(2),
  map(x => x + x),
  takeEveryNthSimple(3),
  map(x => x * x),
  takeEveryNthSimplest(4),
  take(3),
  toArray()
)
.subscribe(x => console.log(x));
// [0, 12, 24]

The correct result is [0, 2304, 9216] and not [0, 12, 24], see the working example on StackBlitz: https://stackblitz.com/edit/rxjs-pipeable-example

[0, 12, 24] would be the result if map(x => x * x) and takeEveryNthSimplest(4) were not in the chain.

@rxjs-bot
Copy link

rxjs-bot commented Mar 7, 2018

Warnings
⚠️

commit message does not follows conventional change log (1)
Messages
📖

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

CJS: 1312.8KB, global: 698.0KB (gzipped: 114.3KB), min: 134.7KB (gzipped: 29.7KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.498% when pulling fd9fae0 on corg:patch-1 into 6319f3c on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Mar 7, 2018

Thanks, @corg!

@benlesh benlesh merged commit d231053 into ReactiveX:master Mar 7, 2018
@SangKa SangKa mentioned this pull request Mar 8, 2018
Closed
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corg @rxjs-bot @coveralls @benlesh